---
phase: 17
slug: gh-issues-client-and-product-catalog
status: draft
nyquist_compliant: false
wave_0_complete: false
created: 2026-03-24
---

# Phase 17 — Validation Strategy

> Per-phase validation contract for feedback sampling during execution.

---

## Test Infrastructure

| Property | Value |
|----------|-------|
| **Framework** | cargo test (Rust built-in) |
| **Config file** | Cargo.toml workspace |
| **Quick run command** | `cargo test -p wit-what-integrations --lib` |
| **Full suite command** | `cargo test --workspace` |
| **Estimated runtime** | ~30 seconds |

---

## Sampling Rate

- **After every task commit:** Run `cargo test -p wit-what-integrations --lib`
- **After every plan wave:** Run `cargo test --workspace`
- **Before `/gsd:verify-work`:** Full suite must be green
- **Max feedback latency:** 30 seconds

---

## Per-Task Verification Map

| Task ID | Plan | Wave | Requirement | Test Type | Automated Command | File Exists | Status |
|---------|------|------|-------------|-----------|-------------------|-------------|--------|
| TBD | TBD | TBD | CLOUD-03 | unit | `cargo test -p wit-what-integrations gh_issues` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | CLOUD-04 | unit | `cargo test -p wit-what-integrations gh_issues` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | PROD-01 | unit | `cargo test -p wit-what-service product` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | PROD-02 | unit | `cargo test -p wit-what-service product` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | PROD-03 | integration | `cargo test -p wit-what-app product_catalog` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | PROD-04 | integration | `cargo test -p wit-what-app product_creation` | ❌ W0 | ⬜ pending |
| TBD | TBD | TBD | PROD-05 | integration | `cargo test -p wit-what-app product_refs` | ❌ W0 | ⬜ pending |

*Status: ⬜ pending · ✅ green · ❌ red · ⚠️ flaky*

---

## Wave 0 Requirements

- [ ] Test stubs for GhIssuesClient CRUD operations
- [ ] Test stubs for Product/ProductUnit SQLite CRUD
- [ ] Test stubs for product catalog UI data building
- [ ] Shared test fixtures for mock gh CLI output

*Existing cargo test infrastructure covers framework needs.*

---

## Manual-Only Verifications

| Behavior | Requirement | Why Manual | Test Instructions |
|----------|-------------|------------|-------------------|
| Product catalog tile grid renders correctly | PROD-03 | Visual UI layout | Open app, navigate to By Product Shipped tab, verify tiles show image + name + count |
| Product ellipsis menu actions work | PROD-03 | UI interaction | Right-click product tile, verify Set Image/View on Shopify/Archive actions |
| Shopify URL auto-suggest in create form | PROD-04 | Requires live Shopify data | Create new product, type in Shopify URL field, verify suggestions appear |
| Product image upload via file picker | PROD-03 | Native OS dialog | Click Set Image, select file, verify upload to orphan branch |

*If none: "All phase behaviors have automated verification."*

---

## Validation Sign-Off

- [ ] All tasks have `<automated>` verify or Wave 0 dependencies
- [ ] Sampling continuity: no 3 consecutive tasks without automated verify
- [ ] Wave 0 covers all MISSING references
- [ ] No watch-mode flags
- [ ] Feedback latency < 30s
- [ ] `nyquist_compliant: true` set in frontmatter

**Approval:** pending