# Phase 17: GH Issues Client and Product Catalog - Gap Closure Discussion Log

> **Audit trail only.** Do not use as input to planning, research, or execution agents.
> Decisions are captured in CONTEXT.md — this log preserves the alternatives considered.

**Date:** 2026-03-26
**Phase:** 17-gh-issues-client-and-product-catalog
**Areas discussed:** Product Detail sidecar location, Serial unit creation UX, Add Product modal parity, Product sync behavior

---

## Product Detail Sidecar Location

| Option | Description | Selected |
|--------|-------------|----------|
| Right sidebar | Docked right, cards fill remaining width, always visible in product-filtered view | |
| Top banner + collapse | Collapsible banner above card grid | |
| Left sidebar | Docked left, replacing tab icons | |

**User's choice:** Right sidebar, but went further — eliminated the ellipsis menu entirely. All ellipsis actions (Set Image, View on Shopify, Product Detail, Archive) move into the sidecar itself.

**Follow-up: Ellipsis menu fate**

| Option | Description | Selected |
|--------|-------------|----------|
| Remove it | Clicking tile is the only way to see product detail | |
| Keep as peek | Two paths to product info | |

**User's choice:** Remove ellipsis menu entirely. Detailed specifications:
- Set Image: hover tooltip on image frame, click to upload
- Archive: full-width button at sidecar bottom
- View on Shopify: clickable URL text
- GH Issue: clickable `beyond-outgoing#123` text

---

## Serial Unit Creation UX

| Option | Description | Selected |
|--------|-------------|----------|
| Inline text input | Click '+', input appears inline, Enter to confirm, auto-generate if blank | ✓ |
| Modal dialog | Small modal with SN field + buttons | |
| Auto-generate only | No SN input, always sequential | |

**User's choice:** Inline text input with auto-focus on spawn.

**Follow-up: What clicking a unit does**

| Option | Description | Selected |
|--------|-------------|----------|
| Open GH Issue in browser | Click unit opens its ww-product-unit issue | |
| Expand inline detail | Shows state, assigned card inline | |
| Nothing | Display-only, remove pointer cursor | |

**User's choice:** Rich radio-button selection model. Selecting a unit: shows SN subtext, "UNIT" badge on image, breadcrumb trail in banner, issue link switches to unit's subissue, card view filters to cards with that unit.

---

## Add Product Modal Parity

| Option | Description | Selected |
|--------|-------------|----------|
| Same visual shell, different content | Reuse modal frame from LookupModal | |
| Reuse LookupModal component | Repurpose LookupModal itself | |
| Keep current form, just fix styling | Match colors/padding/fonts to LookupModal | ✓ |

**User's choice:** Keep current form, fix styling to match LookupModal.

---

## Product Sync Behavior

| Option | Description | Selected |
|--------|-------------|----------|
| Auto-remove on sync | Delete ProductRow if GH Issue gone | |
| Mark as orphaned | Flag as orphaned, show indicator | |
| Keep forever | Never auto-remove | |

**User's choice:** Check GH Issue state: if exists in non-open state, archive locally. If doesn't exist at all, auto-remove from SQLite.

---

## Claude's Discretion

- Product tile hover/ellipsis flicker fix approach
- Sidecar layout details within the specified constraints
- Debounce mechanism for unit creation

## Deferred Ideas

None — discussion stayed within gap closure scope.